Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow illegal usage of expression groups in text Ion 1.1 #1009

Open
tgregg opened this issue Dec 9, 2024 · 0 comments
Open

Disallow illegal usage of expression groups in text Ion 1.1 #1009

tgregg opened this issue Dec 9, 2024 · 0 comments
Labels

Comments

@tgregg
Copy link
Contributor

tgregg commented Dec 9, 2024

IonRawTestReaderTest_1_1.validValuesInvocations contains three tests that should be invalid:

  • (:values (:: (:: 0) (:values (:: 1)))) - Nested expression groups are not allowed (cannot be represented in binary).
  • (:values (:: 0) (:values (:: 1))) - Rest parameter may contain either a single expression group or a sequence of non-group expressions.
  • (:1 (:: (:: 0) (:1 (:: 1)))) - Nested expression groups are not allowed (cannot be represented in binary).

For now they're commented out, but to resolve this issue they should be moved to IonRawTestReaderTest_1_1.invalidExpressionSyntax, with the necessary validation added to the source to reject them.

@tgregg tgregg added the bug label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant