Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Agent.play(previous_turn,game,replay_memory,experience,illegal_moves) #6

Open
amaynez opened this issue Mar 18, 2021 · 0 comments
Assignees
Labels
refactor refactor to improve quality of code

Comments

@amaynez
Copy link
Owner

amaynez commented Mar 18, 2021

I've selected Agent.play(previous_turn,game,replay_memory,experience,illegal_moves) for refactoring, which is a unit of 21 lines of code and 5 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Limit the number of parameters per unit to at most 4.
  • Why
    Keeping the number of parameters low makes units easier to understand, test and reuse.
  • How 🔧
    Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@amaynez amaynez added the refactor refactor to improve quality of code label Mar 18, 2021
@amaynez amaynez self-assigned this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor to improve quality of code
Projects
None yet
Development

No branches or pull requests

1 participant