From b009c28c78883fe77ca19f773523ffdd651e4d82 Mon Sep 17 00:00:00 2001 From: Alex Merose Date: Sun, 23 Jun 2024 13:19:27 +0200 Subject: [PATCH 1/4] Removing gcloud auth until we really need it. Kicking the can down the road... --- .github/workflows/ci-build.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index a66a3fb..633e18e 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -57,12 +57,13 @@ jobs: run: | pip install -e .[tests] - uses: 'actions/checkout@v4' - - id: 'auth' - name: 'Authenticate to Google Cloud' - uses: 'google-github-actions/auth@v1' - with: - service_account: ${{ secrets.SERVICE_ACCOUNT }} - workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_PROVIDER }} +# # TODO(alxmrs): Add back gcloud auth, when it's needed. +# - id: 'auth' +# name: 'Authenticate to Google Cloud' +# uses: 'google-github-actions/auth@v1' +# with: +# service_account: ${{ secrets.SERVICE_ACCOUNT }} +# workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_PROVIDER }} - name: Run unit tests run: | pytest dee \ No newline at end of file From 88ee21ae5a602070ec4c2f9b17a72275607b91f3 Mon Sep 17 00:00:00 2001 From: Alex Merose Date: Sun, 23 Jun 2024 13:22:12 +0200 Subject: [PATCH 2/4] Added a dummy test. --- dee/default_test.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 dee/default_test.py diff --git a/dee/default_test.py b/dee/default_test.py new file mode 100644 index 0000000..c39607b --- /dev/null +++ b/dee/default_test.py @@ -0,0 +1,13 @@ +import unittest + + +class ImportTest(unittest.TestCase): + def test_can_import_dee(self): + try: + import dee + except ModuleNotFoundError: + self.fail('Cannot import `dee`.') + + +if __name__ == '__main__': + unittest.main() From 48398d9101b4264e2d755033456a98fbdad66737 Mon Sep 17 00:00:00 2001 From: Alex Merose Date: Sun, 23 Jun 2024 13:25:39 +0200 Subject: [PATCH 3/4] Passing lint. --- dee/__init__.py | 2 +- dee/default_test.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dee/__init__.py b/dee/__init__.py index 7bb76be..f2166d7 100644 --- a/dee/__init__.py +++ b/dee/__init__.py @@ -1 +1 @@ -# TODO(alxmrs): https://docs.google.com/document/d/1Ltl6XrZ_uGD2J7OW1roUsxhpFxx5QvNeInjuONIkmL8/edit#heading=h.uj7plawe7x7e \ No newline at end of file +# TODO(alxmrs): https://docs.google.com/document/d/1Ltl6XrZ_uGD2J7OW1roUsxhpFxx5QvNeInjuONIkmL8/edit#heading=h.uj7plawe7x7e diff --git a/dee/default_test.py b/dee/default_test.py index c39607b..76643df 100644 --- a/dee/default_test.py +++ b/dee/default_test.py @@ -2,6 +2,7 @@ class ImportTest(unittest.TestCase): + def test_can_import_dee(self): try: import dee From 18dad9203bc2d3eb6c4c61c045dbc314c368e9b9 Mon Sep 17 00:00:00 2001 From: Alex Merose Date: Sun, 23 Jun 2024 13:26:44 +0200 Subject: [PATCH 4/4] Reformatting one more file. --- conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conftest.py b/conftest.py index 5dfc251..ade59ce 100644 --- a/conftest.py +++ b/conftest.py @@ -18,4 +18,4 @@ try: app.run(lambda argv: None) except SystemExit: - pass \ No newline at end of file + pass