From 25037c7aa252c08d063bd17a4c5308808c9e9091 Mon Sep 17 00:00:00 2001
From: Dominic Belcher <dominic.belcher@digital.cabinet-office.gov.uk>
Date: Fri, 18 Oct 2024 14:39:42 +0100
Subject: [PATCH] PP-12828 Update logging in connector client to only record
 5xx responses to GET as error, record non-200 responses as warnings

---
 app/services/clients/connector.client.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/app/services/clients/connector.client.js b/app/services/clients/connector.client.js
index fcea78b95..dad86d5a6 100644
--- a/app/services/clients/connector.client.js
+++ b/app/services/clients/connector.client.js
@@ -197,7 +197,7 @@ async function _getConnector (url, description, loggingFields = {}, callingFunct
     const response = await client.get(`${url}`, description)
     logger.info('GET to %s ended - total time %dms', url, new Date() - startTime, loggingFields)
     incrementStatusCodeCounter(callingFunctionName, response.status)
-    if (response.status !== 200) {
+    if (response.status > 499 && response.status < 600) {
       logger.error(`Error communicating with ${url}`, {
         ...loggingFields,
         service: 'connector',
@@ -205,6 +205,14 @@ async function _getConnector (url, description, loggingFields = {}, callingFunct
         status_code: response.status,
         url: url
       })
+    } else if (response.status !== 200) {
+      logger.warn(`Non-200 response received communicating with ${url}`, {
+        ...loggingFields,
+        service: 'connector',
+        method: 'GET',
+        status_code: response.status,
+        url: url
+      })
     }
     return response
   } catch (err) {