From 82801801939461147250677190191572fbd25e58 Mon Sep 17 00:00:00 2001 From: Alice Lee Date: Mon, 2 Dec 2024 11:14:39 +0000 Subject: [PATCH] Don't error when trying to delete md5 generated username from mysql This was causing the tests to fail because the unbind operation returns an error, even though the broker successfully deleted the actual user that was created. Bindings created after circa 2018 all use the new SHA256 method of username generation, and it's fine if the MD5 generated username doesn't exist, which it almost never will. --- sqlengine/mysql_engine.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sqlengine/mysql_engine.go b/sqlengine/mysql_engine.go index 67f537c5..d284f7e6 100644 --- a/sqlengine/mysql_engine.go +++ b/sqlengine/mysql_engine.go @@ -186,7 +186,7 @@ func (d *MySQLEngine) DropUser(bindingID string) error { return err } - dropUserStatement = "DROP USER `" + username + "`@`%`;" + dropUserStatement = "DROP USER IF EXISTS`" + username + "`@`%`;" logger.Debug("drop-user", lager.Data{"statement": dropUserStatement}) _, err = d.db.Exec(dropUserStatement)