Skip to content
This repository has been archived by the owner on Apr 4, 2018. It is now read-only.

Toolkit js has error #143

Closed
gemmaleigh opened this issue Jan 17, 2017 · 3 comments
Closed

Toolkit js has error #143

gemmaleigh opened this issue Jan 17, 2017 · 3 comments

Comments

@gemmaleigh
Copy link
Contributor

I'm seeing this error in the npm_test app:

toolkit.min.js?0.0.1:1 Uncaught TypeError: e is not a function
    at toolkit.min.js?0.0.1:1
    at toolkit.min.js?0.0.1:1
(anonymous) @ toolkit.min.js?0.0.1:1
(anonymous) @ toolkit.min.js?0.0.1:1
@gemmaleigh gemmaleigh changed the title Compiled toolkit js has error Toolkit js has error Jan 17, 2017
@gemmaleigh
Copy link
Contributor Author

This is because the toolkit JavaScript files use jQuery and it isn't provided by the template.

We're not seeing this error in Fractal as Google hosted jQuery is loaded in the _preview template.

Ideally, the _preview template in Fractal should extend the govuk_layout template.

@gemmaleigh gemmaleigh mentioned this issue Feb 9, 2017
Merged
@dsingleton dsingleton mentioned this issue Feb 9, 2017
Open
@dsingleton
Copy link
Contributor

I've added an issue to remind us to reconsider this for beta: #202

@gemmaleigh
Copy link
Contributor Author

I'm going to close this as we've got a reminder issue in its place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsingleton @gemmaleigh