Run kubeconform against rendered Helm charts #2996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| echo "helm lint for app ${app} with chart ${chart_name}" | ||
| helm lint --quiet -f "${app}" "raw-charts/${chart_name}"; | ||
| if [ $? -ne 0 ]; then | ||
| echo "$output"; |
There was a problem hiding this comment.
I can't see where output is initialised?
There was a problem hiding this comment.
Should it be:
output=$(helm lint --quiet -f "${app}" "raw-charts/${chart_name}")There was a problem hiding this comment.
Also, what does helm lint do that ct isn't already doing?
jasonBirchall
requested changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm lintandkubeconformin parallel to speed up executionextraEnvvalue in thegeneric-govuk-appandasset-managercharts was a map by default instead of a listResolves alphagov/govuk-infrastructure#1713