Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and implement a disabled state #5686

Closed
2 tasks
Tracked by #5626
romaricpascal opened this issue Feb 3, 2025 · 1 comment
Closed
2 tasks
Tracked by #5626

Design and implement a disabled state #5686

romaricpascal opened this issue Feb 3, 2025 · 1 comment
Assignees

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Feb 3, 2025

What

Design and implement a disabled state for the component.

This is only about implementing the visual design, as the disabled state of the component is already synchronised from the <input> to the <button> (avoiding breaking changes for code that may disable an existing <input>).

Why

Despite us not recommending you disable form fields as it causes barriers to users, there's nothing stopping a user disabling the <input> being enhanced and the visual design of the component should reflect that.

Who needs to work on this

Designers + Developers

Note Good opportunity for pairing.

Who needs to review this

Designers + Developers

Done when

  • We have a design for the disabled state
  • Design has been implemented
@CharlotteDowns
Copy link
Contributor

CharlotteDowns commented Feb 4, 2025

When the <button></button> is given a disabled state we change the opacity to .5; and the cursor to not-allowed;

The visible drag drop area and button have 0.5 opacity and a changed cursor to not-allowed

This follows the same behaviour as the secondary button under the same conditions.

You can follow the implementation in this SPIKE #5701

@CharlotteDowns CharlotteDowns moved this from Backlog 🏃🏼‍♀️ to Done 🏁 in GOV.UK Design System cycle board Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants