Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP response object not properly closed when rate limited #307

Open
jcrowthe opened this issue Nov 5, 2024 · 0 comments
Open

HTTP response object not properly closed when rate limited #307

jcrowthe opened this issue Nov 5, 2024 · 0 comments

Comments

@jcrowthe
Copy link

jcrowthe commented Nov 5, 2024

During some thorough testing, I have discovered that when HTTP 429 status codes are returned to the client by Alpaca's Trading API, this client library code will attempt to retry by default. However in the process of doing so, the response body from from the previous attempt is not closed properly. This causes errors to be produced with the following message:

Post "https://paper-api.alpaca.markets/v2/orders": http: ContentLength=446 with Body length 0 

This appears to happen because resp.Body.Close() is only called inside the verify() function, which is called only once and not once per c.httpClient.Do(req).

In my particular situation this is a simple fix now that I know the issue exists. Since retrying is something my code needs to handle explicitly, I decided to simply disable the client.RetryLimit by setting it to 0. Curiously though, client.RetryLimit cannot be set to 0, as it will be overwritten to become 3, as per

}
if opts.RetryLimit == 0 {
opts.RetryLimit = 3
}
I am not positive why this is set this way, so consider this to be a second observation reported in this git issue. My response was to instead set RetryLimit = -1, which does produce the desired result of disabling retries.

So two issues:

  1. Unnecessary error logging is printed on HTTP 429 responses, and
  2. RetryLimit cannot be set to 0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant