From fbd4a53419e960dfc09a936add0769a1d6a3b0a1 Mon Sep 17 00:00:00 2001 From: IG Date: Sun, 31 Dec 2023 14:29:52 +0000 Subject: [PATCH] critical bug fix --- .github/workflows/build.yml | 2 +- docs/release-history.md | 4 ++++ src/Parquet/File/DataColumnWriter.cs | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d5e9a33e..398daa6d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,7 +1,7 @@ name: 'Build' env: - VERSION: 4.18.0 + VERSION: 4.18.1 ASM_VERSION: 4.0.0 DOC_ARTIFACT: webHelp-all.zip diff --git a/docs/release-history.md b/docs/release-history.md index 4ddbc0c4..930a8c46 100644 --- a/docs/release-history.md +++ b/docs/release-history.md @@ -1,3 +1,7 @@ +## 4.18.1 + +Critical bug fix: reverting #423 as it introducing some side effects that prevent from generating correct files. + ## 4.18.0 This is the next stability improvements release, and a big thanks to everyone who contributed! Without you this project would not be possible. diff --git a/src/Parquet/File/DataColumnWriter.cs b/src/Parquet/File/DataColumnWriter.cs index d530393d..64c0aa6b 100644 --- a/src/Parquet/File/DataColumnWriter.cs +++ b/src/Parquet/File/DataColumnWriter.cs @@ -84,7 +84,7 @@ private async Task CompressAndWriteAsync( ph.Write(new Meta.Proto.ThriftCompactProtocolWriter(headerMs)); int headerSize = (int)headerMs.Length; headerMs.Position = 0; - // there used to be a flush here, but removed in #432 due to excessive flushing on expensive streams + _stream.Flush(); await headerMs.CopyToAsync(_stream);