Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Check empty EL reqs newPayloadV4 #395

Closed
emhane opened this issue Jan 17, 2025 · 5 comments · Fixed by #401
Closed

[Feature] Check empty EL reqs newPayloadV4 #395

emhane opened this issue Jan 17, 2025 · 5 comments · Fixed by #401
Assignees
Labels
A-provider Area: provider crate good-first-issue Issues that are easy to pick up for new contributors

Comments

@emhane
Copy link
Collaborator

emhane commented Jan 17, 2025

Component

provider

Describe the feature you would like

Check that execution_requests are always empty

async fn new_payload_v4(
&self,
payload: ExecutionPayloadV3,
parent_beacon_block_root: B256,
execution_requests: Vec<Bytes>,
) -> TransportResult<PayloadStatus> {
// Note: The `versioned_hashes` parameter is always an empty array for OP chains.
let versioned_hashes: Vec<B256> = vec![];
self.client()
.request(
"engine_newPayloadV4",
(payload, versioned_hashes, parent_beacon_block_root, execution_requests),
)
.await
}

Update docs accordingly

/// OP modifications: TODO

Additional context

ethereum-optimism/specs#506

@emhane emhane added A-provider Area: provider crate good-first-issue Issues that are easy to pick up for new contributors labels Jan 17, 2025
@emhane
Copy link
Collaborator Author

emhane commented Jan 17, 2025

matching issue to the spec if you like to work on it @meyer9

@emhane
Copy link
Collaborator Author

emhane commented Jan 17, 2025

inclusion of this in op-reth is blocked by paradigmxyz/reth#13831 cc @mattsse

@meyer9
Copy link

meyer9 commented Jan 17, 2025

sounds good, will do!

@emhane
Copy link
Collaborator Author

emhane commented Jan 21, 2025

@meyer9 this is low prio, tackling this from another easier end for now paradigmxyz/reth#13908

@mattsse
Copy link
Member

mattsse commented Jan 24, 2025

I think this argument should probably be removed from the function itself?
like we do with let versioned_hashes: Vec<B256> = vec![];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-provider Area: provider crate good-first-issue Issues that are easy to pick up for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants