Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Anvil in Provider don't have same types as the rest of the project #1751

Open
NicolasWent opened this issue Dec 4, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NicolasWent
Copy link
Contributor

Component

provider, pubsub, other

Describe the feature you would like

Hello,

In the other parts of alloy, some fields have changed from U256 into u64 and u128, examples:

  • Block number: u64
  • Gas priority and base fee: u128
  • Nonce: u64

These changes are done for when we interact with the real blockchain, but these types differ in the Anvil part of the provider:

Anvil rpc types changes

The same types are present in anvil-rpc-types:

  • NodeEnviornment: base_fee and gas_price should be u128, gas_limit should be u64

Additional context

I think it would be great to keep the same types across all parts of alloy.

@NicolasWent NicolasWent added the enhancement New feature or request label Dec 4, 2024
@mattsse
Copy link
Member

mattsse commented Dec 6, 2024

yep, makes sense, we def want this.

these were originally ported from anvil directly hence the diff.

but should def be unified as much as possible

@mattsse mattsse added the good first issue Good for newcomers label Dec 6, 2024
@varun-doshi
Copy link

Is this available to take up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants