From d34380374dab910b62efdcb2bd0be90d2902f9d5 Mon Sep 17 00:00:00 2001 From: Diego Campo Date: Mon, 16 Dec 2024 20:33:38 +0100 Subject: [PATCH] improve validations on the new params --- x/emissions/types/params.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/x/emissions/types/params.go b/x/emissions/types/params.go index 6f7f552d6..8404e9781 100644 --- a/x/emissions/types/params.go +++ b/x/emissions/types/params.go @@ -623,6 +623,8 @@ func validateMinExperiencedWorkerRegrets(i uint64) error { func validateInferenceOutlierDetectionThreshold(i alloraMath.Dec) error { if err := ValidateDec(i); err != nil { return err + } else if i.IsNegative() { + return ErrValidationMustBeGreaterthanZero } return nil } @@ -630,6 +632,8 @@ func validateInferenceOutlierDetectionThreshold(i alloraMath.Dec) error { func validateInferenceOutlierDetectionAlpha(i alloraMath.Dec) error { if err := ValidateDec(i); err != nil { return err + } else if !isAlloraDecBetweenZeroAndOneInclusive(i) { + return ErrValidationMustBeBetweenZeroAndOne } return nil }