Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): bump actions/setup-python to v5 #827

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

layertwo
Copy link
Contributor

Notes

I noticed when implementing action/test the caching step took a significant amount of time compared to the actual business logic. action/diff doesn't seem to have this behavior.

action/diff is using actions/setup-python@v5, while action/test is using actions/setup-python@v4.

This is important as that action has updated actions/cache@v4 which uses the newer V2 cache. Additionally, all prior versions of actions/cache will start failing in workflows on 2025-02-01.

Solution is to update actions/setup-python to the latest version.

References

@layertwo layertwo marked this pull request as ready for review January 28, 2025 04:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (a29812f) to head (f33bfae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          21       21           
  Lines        2314     2314           
=======================================
  Hits         2170     2170           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit dc1e65e into allenporter:main Jan 31, 2025
25 checks passed
@layertwo layertwo deleted the setup-python-v5 branch February 1, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants