Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep merge issue broke substitutions in 6.1.0 #813

Closed
allenporter opened this issue Dec 26, 2024 · 1 comment · Fixed by #815
Closed

Deep merge issue broke substitutions in 6.1.0 #813

allenporter opened this issue Dec 26, 2024 · 1 comment · Fixed by #815

Comments

@allenporter
Copy link
Owner

allenporter commented Dec 26, 2024 •
edited
Loading

#812 broke merging resulting in issues like https://github.com/onedr0p/home-ops/actions/runs/12473136322/job/34813129881

Source: https://github.com/onedr0p/home-ops/blob/aa26601e17589c8f4fc88d6a68503d53c9943c25/kubernetes/main/apps/kube-system/cilium/app/helmrelease.yaml#L30
@allenporter
Copy link
Owner Author

This may be related to the copy change instead of updating the existing values. Will add a test to reproduce the issue first.

@allenporter allenporter mentioned this issue Dec 26, 2024
Merged
allenporter added a commit that referenced this issue Dec 26, 2024
@allenporter
Fix merging of values to override inline values last (#815)
e3f6de8 
https://fluxcd.io/flux/components/helm/helmreleases/#values-references
specifies that `values` are merged last after any `valuesFrom`
references.

Fixes #813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix merging of values to override inline values last allenporter/flux-local
1 participant
@allenporter