From 60e3283d0333fe310066cc63f29a24de08bd82dc Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Mon, 5 Jun 2023 13:19:57 -0700 Subject: [PATCH 1/6] fix registration --- tango/integrations/torch/optim.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tango/integrations/torch/optim.py b/tango/integrations/torch/optim.py index 54cc2c6b0..a3147a4c3 100644 --- a/tango/integrations/torch/optim.py +++ b/tango/integrations/torch/optim.py @@ -77,7 +77,7 @@ class LRScheduler(torch.optim.lr_scheduler._LRScheduler, Registrable): for name, cls in torch.optim.lr_scheduler.__dict__.items(): if ( isinstance(cls, type) - and issubclass(cls, torch.optim.lr_scheduler._LRScheduler) - and not cls == torch.optim.lr_scheduler._LRScheduler + and issubclass(cls, torch.optim.lr_scheduler.LRScheduler) + and not cls == torch.optim.lr_scheduler.LRScheduler ): LRScheduler.register("torch::" + name)(cls) From 7101c1ef0045d05d7bedfaa2a9fecbb87fc8548b Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Mon, 5 Jun 2023 13:34:54 -0700 Subject: [PATCH 2/6] fix expected output --- tango/integrations/transformers/__init__.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tango/integrations/transformers/__init__.py b/tango/integrations/transformers/__init__.py index 6d9526717..57c1d3646 100644 --- a/tango/integrations/transformers/__init__.py +++ b/tango/integrations/transformers/__init__.py @@ -72,6 +72,8 @@ transformers::AutoModelForImageSegmentation::from_pretrained transformers::AutoModelForInstanceSegmentation::from_config transformers::AutoModelForInstanceSegmentation::from_pretrained + transformers::AutoModelForMaskGeneration::from_config + transformers::AutoModelForMaskGeneration::from_pretrained transformers::AutoModelForMaskedImageModeling::from_config transformers::AutoModelForMaskedImageModeling::from_pretrained transformers::AutoModelForMaskedLM::from_config From 8399d764330a3f7860d454704fa3ccc150e20442 Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Mon, 5 Jun 2023 13:37:35 -0700 Subject: [PATCH 3/6] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 917f69fb9..0939be634 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Removed unnecessary code coverage dev requirements. +- Fixed issue where new version of torch caused no LR schedulers to be registered. ## [v1.2.1](https://github.com/allenai/tango/releases/tag/v1.2.1) - 2023-04-06 From 9338c062114b9244d9752c5d2af1346ae0993aed Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Tue, 11 Jul 2023 11:19:59 -0700 Subject: [PATCH 4/6] fix doctest --- tango/integrations/transformers/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tango/integrations/transformers/__init__.py b/tango/integrations/transformers/__init__.py index 57c1d3646..927a126a2 100644 --- a/tango/integrations/transformers/__init__.py +++ b/tango/integrations/transformers/__init__.py @@ -161,6 +161,7 @@ transformers::inverse_sqrt transformers::linear transformers::polynomial + transformers::reduce_lr_on_plateau - :class:`~tango.integrations.torch.DataCollator`: All data collators from transformers are registered according to their class name (e.g. "transformers::DefaultDataCollator"). From 1b2333f2872a78563ef94a086727d2a5ec9c28d6 Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Tue, 11 Jul 2023 11:49:41 -0700 Subject: [PATCH 5/6] click's latest version broke things --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 6f7a64c2d..5548dfd91 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -28,7 +28,7 @@ dependencies = [ "base58", "xxhash", "filelock>=3.4,<4.0", - "click>=8.0,<9.0", + "click>=8.0,<8.1.4", "click-help-colors>=0.9.1,<0.10", "rich>=12.3,<14.0", "tqdm>=4.62,<5.0", From 1149c5e682d35f1fbef3a290e710d2a5ef0d04b3 Mon Sep 17 00:00:00 2001 From: Akshita Bhagia Date: Tue, 11 Jul 2023 13:22:17 -0700 Subject: [PATCH 6/6] update default cluster --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 2a327176f..d1b7b4a0c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -20,7 +20,7 @@ env: WANDB_API_KEY: ${{ secrets.WANDB_API_KEY }} BEAKER_TOKEN: ${{ secrets.BEAKER_TOKEN }} BEAKER_WORKSPACE: ai2/tango-testing - BEAKER_DEFAULT_CLUSTER: ai2/tango-gpu-tests + BEAKER_DEFAULT_CLUSTER: ai2/allennlp-cirrascale BEAKER_IMAGE: petew/tango-testing GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}