Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to display the executor output #491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ability to display the executor output #491

wants to merge 3 commits into from

Conversation

BigRedT
Copy link
Contributor

@BigRedT BigRedT commented Dec 9, 2022 •
edited
Loading

Fixes #487

Changes proposed in this pull request:
Lightly modified version of code pointed by @epwalsh here

Adds the ability to display the executor output. Can be used as follows:

output = executor.execute_step_graph(step_graph)
output.display()

Tested locally and produces an output as follows:

Screen Shot 2022-12-09 at 3 11 13 PM

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@BigRedT
Update executor.py
609c065 
Add ability to display the executor output. Can be used as follows:

```python
output = executor.execute_step_graph(step_graph)
output.display()
```
@BigRedT BigRedT requested a review from epwalsh December 9, 2022 23:12
@BigRedT BigRedT mentioned this pull request Dec 9, 2022
Open
epwalsh
epwalsh reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I think the CI failures are all minor. Try running black . and isort . to fix formatting. Then run flake8 . and mypy . to see what they're complaining about

@BigRedT
Copy link
Contributor Author

BigRedT commented Dec 10, 2022

@epwalsh fixed the formatting issues. Not sure if the remaining 3 failing checks are related to this PR?

epwalsh
epwalsh reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the old code in tango/__main__.py to just calling this new method? Don't worry about the remaining failing tests in CI

@apoorvkh apoorvkh mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwalsh epwalsh epwalsh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I get nice formatted terminal logs when using hydra instead of tango's jsonnet configs
2 participants
@BigRedT @epwalsh