Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.optim.lr_scheduler.ReduceLROnPlateau not registered #482

Open
lgessler opened this issue Dec 5, 2022 · 1 comment
Open

torch.optim.lr_scheduler.ReduceLROnPlateau not registered #482

lgessler opened this issue Dec 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@lgessler
Copy link

lgessler commented Dec 5, 2022

🐛 Describe the bug

For some reason, PyTorch's ReduceLROnPlateau learning rate scheduler is not registered as a subclass of LRScheduler. This causes Tango's registration to fail to register it, as Tango uses a subclass of LRScheduler check to see whether a given class ought to be registered.

Suggested fix: manually include ReduceLROnPlateau in Tango's registration code. I'd be happy to open a PR for this.

Versions

ai2tango==1.0.2
torch==1.13.0
@lgessler lgessler added the bug Something isn't working label Dec 5, 2022
@lgessler
Copy link
Author

lgessler commented Dec 5, 2022

OK, I actually see that ReduceLROnPlateau.step requires a metrics argument, while other PyTorch LR schedulers do not. This which would complicate Tango's training implementation, so the fix is not as easy as I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant