Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change canvas aspect ratio based on loaded dataset #337

Open
ShrimpCryptid opened this issue May 3, 2024 · 0 comments
Open

Change canvas aspect ratio based on loaded dataset #337

ShrimpCryptid opened this issue May 3, 2024 · 0 comments
Labels
new feature New feature or request

Comments

@ShrimpCryptid
Copy link
Contributor

Use Case

Canvas aspect ratio is currently a hardcoded value (roughly 7:5). It would be nice to resize the canvas viewport based on the loaded frame dimensions of the dataset, so we minimize any gutters around the frame.

image

See line: https://github.com/allen-cell-animated/nucmorph-colorizer/blob/main/src/components/CanvasWrapper.tsx#L14

Acceptance Criteria

Please describe how you know this is done

Details

  • Are dataset frames ever going to resize unexpectedly? Will this behave well for very long or very narrow frame sizes?
@ShrimpCryptid ShrimpCryptid added the new feature New feature or request label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant