Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose limit to be configurable from UI / command line #1050

Open
lukass77 opened this issue Mar 14, 2023 · 5 comments
Open

expose limit to be configurable from UI / command line #1050

lukass77 opened this issue Mar 14, 2023 · 5 comments

Comments

@lukass77
Copy link

lukass77 commented Mar 14, 2023

saw that on 1.39.0 the default limit is 100 for sort by
can we configure the default limit to be smaller .. so on the first query hit ..
query will not process 100 entries by default ..
default will be 100 , but in case limit value is provided it will overwrite the default value with the provided value

I asume smaller limit can improve performance ..in case user need smaller limit

@adrianmroz-allegro
Copy link
Contributor

Please note few things:

  1. The '100' is not a hardcoded value. Default limit for Splits is chosen based on Dimension available limits.
  2. Dimension limits are already customisable - each dimension can have different limits.
  3. Visualisations can affect limits so it is not set in stone.

It would be impossible to create one setting for this. And I'm afraid it will be very hard to understand what it really does. I much prefer to avoid unnecessary configurations - they have very high maintenance cost.

@lukass77
Copy link
Author

lukass77 commented Mar 16, 2023 via email

@adrianmroz
Copy link
Collaborator

It's just property limits in dimension configuration.

I see it's not in the documentation. I'll add it tomorrow!

@lukass77
Copy link
Author

lukass77 commented Apr 2, 2023

Hey any update on this , documentation change ?

@adrianmroz-allegro
Copy link
Contributor

Documentation added in #1058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants