Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues #38

Open
1 of 7 tasks
alistair-marshall opened this issue Apr 15, 2020 · 2 comments
Open
1 of 7 tasks

Fix accessibility issues #38

alistair-marshall opened this issue Apr 15, 2020 · 2 comments

Comments

@alistair-marshall
Copy link
Owner

alistair-marshall commented Apr 15, 2020

Running lighthouse on Chrome reveals a few accessibility issues that need to be fixed:

  • Contrast
  • Form labels

After performing another audit using Wave:

  • Add Alt text to help question marks
  • Add labels to form data spending floor/ceiling values
  • Add labels to name of simulation (do we even need this form element?)
  • Three empty table headers (replace empty with empty )
  • Fix labels for modal popups.
@alistair-marshall
Copy link
Owner Author

Table form labels fixed with #40.

@alistair-marshall
Copy link
Owner Author

After fixing the form labels, the lighthouse score jumped to 98%.

The contrast issues are the blue headers and the green buttons. I am fairly sure these are default bootstrap choices and are still pretty clear.

The colours will probably be changed if the project gets rebranded, so this bug can wait for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant