virt-build-kata: review the parameters passed to virt-install

[fidencio]

Here, I'd just like to check & suggest whether we need the parameters currently used.

We use, for now:

• --ram, I'd suggest using --memory instead, just because it was introduced in order to deprecate --ram;
• --vcpus`, that's ok;
• --disk, that's ok;
• --graphics vnc,listen=0.0.0.0, do we have to pass that? or can se just fallback to the console and happy about that?
• --os-type=$osvariant, similarly to the --ram / --memory case, we better use --os-variant here;
• --network network=default, why do we need this?

Last but not least, I wonder whether we could be opinionated and force people to use -c qemu:///system just to ensure we'll, later on, be able to ssh into the machine.

What do you think?

[alicefr]

Here, I'd just like to check & suggest whether we need the parameters currently used.

We use, for now:

• --ram, I'd suggest using --memory instead, just because it was introduced in order to deprecate --ram;

Ok, I'll change

• --vcpus`, that's ok;
• --disk, that's ok;
• --graphics vnc,listen=0.0.0.0, do we have to pass that? or can se just fallback to the console and happy about that?

I had to add it because for ubuntu I was not able to see the console. This seems to be a known issue and you need to activate the serial getty consoe. I actually have it as firstboot param, so I can remove this.

• --os-type=$osvariant, similarly to the --ram / --memory case, we better use --os-variant here;

Ok thanks

• --network network=default, why do we need this?

No, I don't think we need it. It was me with the wrong setup. Maybe I'll put an optional flag is people want to configure the network

Last but not least, I wonder whether we could be opinionated and force people to use -c qemu:///system just to ensure we'll, later on, be able to ssh into the machine.

I'm not very familiar with the session mode. If you think, it's better we can configure it.

What do you think?