Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-build-kata: don't hardcode the disk image name #1

Open
fidencio opened this issue Feb 15, 2021 · 1 comment
Open

virt-build-kata: don't hardcode the disk image name #1

fidencio opened this issue Feb 15, 2021 · 1 comment

Comments

@fidencio
Copy link

This script could be used for spawning several VMs in parallel, which would result in errors in case the disk is not set by the user.

Here, I'd recommend a few things:

  1. Instead of kata.qcow2, use kata-$d.qcow2 by default, as this would already allow users to have different distros running in parallel;
  2. Check whether $disk already exists in the system, just to avoid overwriting something without advertising the user;

Note, I thought about trying a pseudo smart approach of naming the image kata-$d, checking for the existence, and creating a kata-$d-nn instead. However, I sincerely think it's over-engineering the problem at this point and I'd be way happier with only 1 and 2 being implemented.

@alicefr
Copy link
Owner

alicefr commented Feb 17, 2021

I put the disk image as a mandatory parameter. So, it's the responsibility of the user to set the name and path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants