Open file descriptor leak in qdisc?

[dreamerlzl]

Environment

kubeskoop version: v0.1.1
configuration:

port: 9102
sinks:
  - name: stderr
enable_controller: false
metrics:
  probes:
  - name: qdisc

What happened?

The number of open file descriptors by kubeskoop's container inspector keeps increasing until reaching the node limit.

here in the picture, there are 6 namespaces in the k8s cluster. The number of open fd increases periodically.

What is expected to happen?

The count of open file descriptor by kubeskoop doesn't grow infinitely, or
the maximum of open file descriptors allowed for kubeskoop is configurable or have a reasonable default value during launch.

How to reproduce

Run kubeskoop in any real k8s cluster where the nodes are bare metals.

[jzwlqx]

@dreamerlzl hi, I didn't see this issue in my own environment.

Which process had the pid 3786437 in your screenshot, and this issue only happened in bare metal k8s nodes?

[jzwlqx]

I got it. I previously added a todo in the code to remind myself to check whether the file descriptor was closed, but I ended up forgetting about it.

kubeskoop/pkg/exporter/nettop/cache.go

Line 198 in ee50092

//TODO check whether we should close the opened file

[dreamerlzl]

@dreamerlzl hi, I didn't see this issue in my own environment.

Which process had the pid 3786437 in your screenshot, and this issue only happened in bare metal k8s nodes?

Thank you for the reply.
The process in the snapshot is inspector, sorry for missing it.