We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/alibaba/kubeskoop/blob/2e79815afe27463313ca73f44e789ea97414cc19/pkg/exporter/cmd/server.go#L299C1-L314C1
In our case, we use serveral sinks config, like:
... sinks: - name: kafka args: addr: ... topic: ... - name: elasticsearch args: addr: ... index: ...
if something wrong with kafka, when we start exporter, the whole metricServer will stop.
I think it's better to record the err log instead of return. Because the second sink we used is valid, we hope events push to elasticsearch.
//sink sinks, err := createSink(cfg.EventConfig.EventSinks) if err != nil { log.Errorf("failed create sinks, err: %v", err) return }
The text was updated successfully, but these errors were encountered:
#264
Sorry, something went wrong.
No branches or pull requests
https://github.com/alibaba/kubeskoop/blob/2e79815afe27463313ca73f44e789ea97414cc19/pkg/exporter/cmd/server.go#L299C1-L314C1
In our case, we use serveral sinks config, like:
if something wrong with kafka, when we start exporter, the whole metricServer will stop.
I think it's better to record the err log instead of return. Because the second sink we used is valid, we hope events push to elasticsearch.
The text was updated successfully, but these errors were encountered: