Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization for tracevirtcmdlat #193

Closed
dzy176 opened this issue Feb 20, 2024 · 2 comments
Closed

Optimization for tracevirtcmdlat #193

dzy176 opened this issue Feb 20, 2024 · 2 comments

Comments

@dzy176
Copy link
Contributor

dzy176 commented Feb 20, 2024

Hi, @Lyt99 , I have doubts about the metric calculation logic in tracevirtcmdlat.
The current logic is as follows:

if event.Latency > 100000000 {
	p.updateMetrics(VIRTCMD100MS)
} else {
	p.updateMetrics(VIRTCMD)
}

Would it be better to change it in this way? The VIRTCMD metric should contains the VIRTCMD100MS metric.

p.updateMetrics(VIRTCMD)

if event.Latency > 100000000 {
	p.updateMetrics(VIRTCMD100MS)
} 
@Lyt99
Copy link
Collaborator

Lyt99 commented Feb 21, 2024

Hi, thanks for your issue!

It's reasonable for me to make VIRTCMD contain VIRTCMD100MS, and so do other probes like socketlatency, kernellatnecy, etc.

If you are willing to, cloud you please take a look at these probes, and make a PR for it?

@dzy176
Copy link
Contributor Author

dzy176 commented Feb 21, 2024

PR #194, please review 😄😄😄😄

@dzy176 dzy176 closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants