New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Context parallelism not enabled in SFT #189

Open

slimfrkha opened this issue Dec 24, 2024 · 0 comments

slimfrkha commented Dec 24, 2024

Describe the bug
get_batch doesnt support cp broadcasting. Running with cp > 1 on current code yields wrong loss

To Reproduce
any same SFT experiment with cp=1 then cp=2

Expected behavior
cp=1 or cp=2 should yield very similar lm loss

Screenshots

slimfrkha mentioned this issue

Enable context parallelism in SFT #190

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment