Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble building instantsearch.js from source #6301

Open
1 task done
Janik-Haag opened this issue Jul 26, 2024 · 1 comment
Open
1 task done

Trouble building instantsearch.js from source #6301

Janik-Haag opened this issue Jul 26, 2024 · 1 comment
Labels
triage Issues to be categorized by the team

Comments

@Janik-Haag
Copy link

🐛 Current behavior

When trying to build instantsearch.js from source, I get a different and broken result compared to the one located at https://cdn.jsdelivr.net/npm/instantsearch.js@4

image
(diff produced with delta)

🔍 Steps to reproduce

git clone [email protected]:algolia/instantsearch.git
cd instantsearch/
yarn install
cd packages/instantsearch.js
yarn build:umd
wget https://cdn.jsdelivr.net/npm/instantsearch.js@4
diff instantsearch.js@4 dist/instantsearch.production.min.js

(the reproduction link is empty* because it shouldn't be relevant for this bug)

Live reproduction

https://example.com/

💭 Expected behavior

I'd expect to get the same output, or at least a working version.
I also tried building with the latest instantsearch.js tag, but that produced the same non working result.

Package version

gituhub.com/algolia/instantsearch.git/master

Operating system

Linux-NixOS 24.05

Browser

Mozilla Firefox 128.0.2

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Janik-Haag Janik-Haag added the triage Issues to be categorized by the team label Jul 26, 2024
@Haroenv
Copy link
Contributor

Haroenv commented Jul 30, 2024

I can't retry this locally, when you did your install, did it build instantsearch-ui-components as well? normally the install should trigger that. There's been a release since your issue and it also worked fine (no require of instantsearch-ui-components). Have you made any changes before you built?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues to be categorized by the team
Projects
None yet
Development

No branches or pull requests

2 participants