-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth 2 - Google - After Sigin not redirected back to app #138
Comments
@alexziskind1 ..Please help |
include this at manifest activity tag android:launchMode="singleTask" |
After Sigin not redirected back to app in IOS |
I also get following error, when should be redirected to app:
|
Having the same issue - after sign in redirects to google.com |
I have exactly the same problem. I have no clue how to fix this... did anybody succeded? |
I am still waiting for the resolution |
I modified index.ios.js to make it work for now. Replaced this.handleIncomingUrl to TnsOAuthClientAppDelegate.prototype.handleIncomingUrl. |
That's great! If that solves the problem then would you like to open a Pull Request? |
It works, but this is just a workaround. It's not right to call prototype directly. |
It is a change in js file, generated after build. I don't now what should be changed in source, so can't open a pull request. |
Where are this file and this code? i can't find it in my project |
At first I modified it directly in node_modules/nativescript-oauth2/delegate/index.ios.js |
|
Confirmed this is an issue on Android, not on iOS. Unaware of a fix at this time. Open to review PRs. |
hi Alex @alexziskind1. I have the same issue as described above on ios with v3.0.1 of the plugin. The above fix worked for me as well even taught it should just be a temporary one as it's changing the .js file. So the PR motioned above that you close might be a valid one after all. There was also a discussion in #135 that looks related even taught it says it's related to firebase. |
Did not solved the problem |
I am having this issue on a new angular code share project with the android emulated app. Angular 11.0.4, Nativescript 7.0.0, "nativescript-oauth2": "^3.0.3" tried editing the androidManifest.xml file with both neither worked for returning to app here is the google tnsOaProvider set up:
I do not et any errors in the console when I open the debug tools via: From what I can trace, in the node_modules/nativescript-oauth2/delegate/index.android.js file line 3: the above "fix" from OniQ is only relevant for ios users even though the issue is with android as well. |
My code is working fine before in iOS but now its redirecting to a google page after sign-in instead back to app, if you press done the tokenResult will be null the error result will be "The login operation was canceled". with error Its working fine before, not sure what happen. We also have firebase plugin on our app |
any update on this issue on android? |
so don't know if this helps tested on two emulators with android 9 and 10, noticed it worked on 10 not 9 for me |
Tried using this on Default Pixel 4 image on android studio with android 11, default pixel 3 image with android 10, and pixel 2 with android 9, none of them worked for google integration. Just logged user in to google account and did not redirect back to app. I would be willing to put some time into this but I am not sure where to start, can someone help me identify where to start debugging this issue? |
Thanks for offering to help @kingjordan . This could be an issue with Android API level support or AndroidX library detection. Take a look at the gradle file included with the plug-in and the previous versions of the file and how it was changed. Accepting PRs. |
This also happen on iOS after we implemented firebase for our push notification. After the user successfully logins it proceed to a goole search page instead of redirecting to the app. |
@alexziskind1 thanks for the help getting started. I was not able to get any solution. I tried the following:
I also tried with current version of play services v19 and again, no solution
I am not sure what else I can do to test this thanks |
Any update on this? or can anyone recommend another plugin that works with firebase? |
Thanks to @OniQ for the iOS workaround. We hope it will be fixed soon. |
I have started today with this plugin and I have encountered the problem on IOS. |
@christiannepomuceno , did you managed to fix it. I have the same error. |
@alexziskind1 This is an IOS issue and I've tried to also add |
Any update on this? Same problem for IOS |
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
node_modules/tns-core-modules/package.json
file in your project)"tns-android"
and"tns-ios"
properties in thepackage.json
file of your project)package.json
file of yourproject and paste your dependencies and devDependencies here)
Please, tell us how to recreate the issue in as much detail as possible.
I have integrated the latest version of Oauth -2. After I hit the signin button for Google, it prompt me for login(already loggedin users) on chrome. After I select the login, the browser does not come back to App. It just opens google.com.
I am using exactly same code mentioned in the demo app except the client id and other keys. This used to work for me earlier, it suddenly stopped working. This is working fine on my phone, not working on emulator.
Is there any code involved?
The text was updated successfully, but these errors were encountered: