Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Device Names / Changing Device Names #57

Open
swilalaa opened this issue Nov 27, 2022 · 2 comments
Open

Unique Device Names / Changing Device Names #57

swilalaa opened this issue Nov 27, 2022 · 2 comments

Comments

@swilalaa
Copy link

swilalaa commented Nov 27, 2022

The plugin picks up the device name set up in the webinterface of the shelly device, however it can't be changed afterwards and is not picking up an updated device name.

This causes issues if the shellys are used in plugins such as homebridge-alexa as the devices with the same device names are recognized as duplicates and therefore skipped for adding.

Could you please either build in a logic that creates always unique device names (eg. shelly plus1 N+1) or build in a logic like this that lets the user update the device name in homebridge?

if (this.services[uniq_id] && this.services[uniq_id].service && this.services[uniq_id].service.getCharacteristic(this.Characteristic.ConfiguredName).listenerCount('set') < 1) {

            (this.services[uniq_id].service.getCharacteristic(this.Characteristic.ConfiguredName) ||
              this.services[uniq_id].service.addCharacteristic(this.Characteristic.ConfiguredName))
              .on('set', setConfiguredName.bind(this.services[uniq_id]));
          }

Many thanks in advance!

@nscheffer
Copy link

Same for me, any update ?

@HDeKnop
Copy link

HDeKnop commented Mar 3, 2024

yes here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants