Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with epoch containing hundredth of seconds will return all #94

Open
lukrido opened this issue May 30, 2018 · 1 comment
Open

Comments

@lukrido
Copy link

lukrido commented May 30, 2018

Hello

If the epoch has a decimal in min_taken_date/max_taken_date/min_upload_date/max_upload_date, the API returns the complete set of pictures instead of the search request.
Such decimal is caused by the hundredth of seconds in the epoch notation.
1527638245 is valid, but 1527638245.75 isn't.
This can be reproduced here:
https://www.flickr.com/services/api/explore/flickr.photos.search

Should the epoch automatically be converted to an integer to make sure we are always on the safe side?

Cheers,

@mtrovo
Copy link
Collaborator

mtrovo commented Jun 4, 2018

That's really a strange behaviour, it seems the input validation on their side is broken for date fields.

It would be cool to have a way to sanitize arguments to avoid this kind of problem, I think we can have a type field on the objects on methods.py file and do a validation phase before sending the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants