add tests for helm utils #987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Oct 9, 2023
| want: ValuesMap{}, | ||
| }, | ||
| { | ||
| name: "invalid yaml file", |
There was a problem hiding this comment.
What's invalid about this YAML file, perhaps the test case name could say?
There was a problem hiding this comment.
replicaCount: 1
image:
repository: nginxnot properly indented.
There was a problem hiding this comment.
That looks like properly indented YAML to me?
But it sounds like you've come up with a great name for the test case.
There was a problem hiding this comment.
shouldn't valid yaml will look like below? There is no proper indentation.
replicaCount: 1
image:
repository: nginx
alexellis
reviewed
Oct 9, 2023
| }{ | ||
| { | ||
| name: "valid yaml file", | ||
| content: ` |
There was a problem hiding this comment.
There should also be a test for when image: is at the top level of the file for things like inlets-operator.
There was a problem hiding this comment.
updated content with a top level image key.
Signed-off-by: Nitishkumar Singh <[email protected]>
nitishkumar71
force-pushed
the
helm_unit_test
branch
from
f4ebc33 to
187633e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for helm utils
Motivation and Context
design/approvedby a maintainer (required)Closes Add e2e test for helm utils #986
How Has This Been Tested?
If updating or adding a new CLI to
arkade get, run:NA. As it's logic tests included , so nothing additional tests are needed to be done.
Types of changes
Documentation
./arkade get --format markdown./arkade install --helpChecklist:
git commit -s