Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ [Immich] Breaking change next release #1138

Closed
hydazz opened this issue Dec 16, 2023 · 9 comments
Closed

⚠️ [Immich] Breaking change next release #1138

hydazz opened this issue Dec 16, 2023 · 9 comments
Labels
Priority stale Element will be closed automatically

Comments

@hydazz
Copy link

hydazz commented Dec 16, 2023

Thought I would give you a heads up that once imagegenius/docker-immich#248 is merged, instances will stop working, people will need to update their postgres image to pgvector

@hydazz hydazz added the prevent stale Prevents stale being applied label Dec 16, 2023
@alexbelgium
Copy link
Owner

Thanks very much!

@alexbelgium
Copy link
Owner

I don't think postgres supports automatic database updates, so would this means I would need to create an addon for the postgres vector image, and users would have to recreate their databases using the new vector database addon ?

@hydazz
Copy link
Author

hydazz commented Dec 16, 2023

no migration is needed just have to swap out the container for tensorchord/pgvecto-rs:pg14-v0.1.11 - there should be images for postgres 14/15/16, if keeping the same version, no recreation needed (which is easier said then done when you dont have to work within the restrictions of haos)

@alexbelgium
Copy link
Owner

Great thanks!

@pafnow
Copy link

pafnow commented Jan 8, 2024

Hi,
Is this issue preventing the upgrade of the addon to the last version of immich ?

@hydazz
Copy link
Author

hydazz commented Jan 10, 2024

I would assume so, every instance would break unless the postgres container is changed to vector.rs

@alexbelgium
Copy link
Owner

Hi, indeed I just didn't found time to make the test environment to upgrade the postgres container, see if custom scripts need to be updated and check the impact on other addons depending on it.

So for the moment I've paused the updates to be sure that nothing breaks for current users

alexbelgium added a commit that referenced this issue Jan 31, 2024
alexbelgium added a commit that referenced this issue Jan 31, 2024
alexbelgium added a commit that referenced this issue Jan 31, 2024
@alexbelgium
Copy link
Owner

alexbelgium commented Jan 31, 2024

I've updated the postgres image, if there is no reported issues the immich image will be updated next saturday

thanks VERY MUCH for that advance notice that ensured to do things in a progressive and hopefully non disruptive manner!

@alexbelgium alexbelgium removed the prevent stale Prevents stale being applied label Jan 31, 2024
alexbelgium added a commit that referenced this issue Jan 31, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Element will be closed automatically label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority stale Element will be closed automatically
Projects
None yet
Development

No branches or pull requests

3 participants