Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Local Credential Hijacking fix #475

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: Local Credential Hijacking fix #475

merged 1 commit into from
Jun 13, 2023

Conversation

LucioMS
Copy link
Contributor

@LucioMS LucioMS commented Jun 12, 2023 •
edited
Loading

Added a confirmation the browser has been used to sign in to alexa before closing the port.

DX for no:

% ask configure
This command will configure the ASK CLI with a profile associated with your Amazon developer credentials.
------------------------- Step 1 of 2 : ASK CLI Configuration -------------------------
? Please create a new profile or overwrite the existing profile.
 [x]                       ** NULL **
[Warn]: ASK CLI uses authorization code to fetch LWA tokens. Do not share neither your authorization code nor access tokens.
Switch to "Login with Amazon" page and sign-in with your Amazon developer credentials.
If your browser did not open the page, try to run the command again with "--no-browser" option.

? Do you confirm using the browser to sign in to Alexa Skills Kit Tools? No
[Error]: Stopping configuration with unconfirmed browser sign in.

DX for yes:

 % ask configure
This command will configure the ASK CLI with a profile associated with your Amazon developer credentials.
------------------------- Step 1 of 2 : ASK CLI Configuration -------------------------
? Please create a new profile or overwrite the existing profile.
 [x]                       ** NULL **
[Warn]: ASK CLI uses authorization code to fetch LWA tokens. Do not share neither your authorization code nor access tokens.
Switch to "Login with Amazon" page and sign-in with your Amazon developer credentials.
If your browser did not open the page, try to run the command again with "--no-browser" option.

? Do you confirm using the browser to sign in to Alexa Skills Kit Tools? Yes
ASK Profile "x" was successfully created. The details are recorded in ask-cli config file (.ask/cli_config) located at your **HOME** folder.
Vendor ID set as M1UCNFO4KV3AAA.

------------------------- Step 2 of 2 : Associate an AWS Profile with ASK CLI -------------------------
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot requested a review from tydonelson June 12, 2023 21:07
@LucioMS LucioMS force-pushed the lumas/localCred branch 2 times, most recently from 8512c61 to 300a249 Compare June 13, 2023 10:05
@LucioMS LucioMS requested a review from doiron June 13, 2023 10:07
@github-actions github-actions bot requested a review from tydonelson June 13, 2023 20:47
@LucioMS LucioMS removed the request for review from doiron June 13, 2023 22:01
@LucioMS LucioMS merged commit 40d98ef into develop Jun 13, 2023
doiron
doiron reviewed Jun 13, 2023
View reviewed changes
lib/controllers/authorization-controller/index.js
ui.confirmAllowSignIn((error, confirmSignInChoice) => {
// After confirmed or not browser sign in, closes the socket/port
// with server.destroy().
// We need to keep the port open so a local hacker is not be able to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the part about local hackers

@LucioMS LucioMS linked an issue Jun 14, 2023 that may be closed by this pull request
Local HTTP server credential hijacking #476
Closed
LucioMS added a commit that referenced this pull request Jul 5, 2023
@LucioMS
bug: Local Credential Hijacking fix => round 2
e096f42 
#475
@LucioMS LucioMS mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doiron doiron doiron left review comments

@tydonelson tydonelson tydonelson approved these changes

Assignees

@LucioMS LucioMS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local HTTP server credential hijacking
3 participants
@LucioMS @doiron @tydonelson