Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove withCustomerUserAgent() from index.js in Alexa-hosted skills template #420

Closed
habuma opened this issue Oct 27, 2021 · 2 comments
Closed

Comments

@habuma
Copy link

habuma commented Oct 27, 2021

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request 
[X] Other... Please describe: Remove the call to `withCustomUserAgent()` from the lambda/index.js file in the Alexa-hosted skills template.



## Expected Behavior
The `withCustomUserAgent()` call is optional and generally unnecessary (except for special circumstances, in which the developer can add it themselves). In the interest of simplifying the template, this should not be in the template.

## Current Behavior
(see above)

## Steps to Reproduce (for bugs)
Use `ask new` to create a new Node.js, Alexa-hosted skills project. Observe that in lambda/index.js there is a call to `withCustomUserAgent()` near the end. 

## Possible Solution
Remove the call to `withCustomUserAgent()`.

## Your Environment and Context

* ask-cli version: 2.24.1
* Operating System and version: MacOS 11.6
* Node.js version used for development: 16.6.1
* NPM version used for development: 7.24.1
@CamdenFoucht
Copy link
Contributor

Thank you for the suggestion, I will reach out to the team that owns that template to see if they will change it.

@doiron
Copy link
Contributor

doiron commented Jan 20, 2023

duplicate skill-sample-nodejs-hello-world/issues/43

thanks for filing a issue on the sample skill repository itself.

@doiron doiron closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants