Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react 17 #117

Closed
MatanYemini opened this issue Jan 22, 2022 · 9 comments · Fixed by #145
Closed

Update to react 17 #117

MatanYemini opened this issue Jan 22, 2022 · 9 comments · Fixed by #145
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MatanYemini
Copy link

I don't think that description is needed.

I don't mind to do, just update me if you allow.

Thanks.

@MatanYemini MatanYemini added the enhancement New feature or request label Jan 22, 2022
@cgarrovillo
Copy link

What do you think needs updating? AFAIK this is still compatible with React 17.

@cassm
Copy link

cassm commented Mar 9, 2022

I believe I've run into the same issue here. As suggested in the error message, it does work fine with --legacy-peer-deps, so it's not critical.

Steps to reproduce: run npm install --save @koale/useworker in a project which uses React 17.0.2
Expected result: package installs
Actual result: receive the following error:
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @koale/[email protected]
npm ERR! node_modules/@koale/useworker
npm ERR! @koale/useworker@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/cassm/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/cassm/.npm/_logs/2022-03-09T12_41_04_040Z-debug-0.log

The mentioned log files are attached.
eresolve-report.txt
2022-03-09T12_41_04_040Z-debug-0.log

@VittorioAccomazzi
Copy link

Same issue with react 18:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @koale/[email protected]
npm ERR! node_modules/@koale/useworker
npm ERR!   @koale/useworker@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/vittorio/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/vittorio/.npm/_logs/2022-04-09T14_41_58_833Z-debug-0.log

however using --legacy-peer-deps seems to workaround the problem

@jonbeacherdomuso
Copy link

I have the same issue and I cant fix with --legacy-peer-deps

@alewin
Copy link
Owner

alewin commented Dec 11, 2022

I will fix this in the next release, thanks!

@atrakh
Copy link

atrakh commented Mar 3, 2023

Any timeline on the next release?

@yezzer
Copy link

yezzer commented Mar 23, 2023

Any update on this @alewin ? :)

@Mariam-maghraby
Copy link

When will be the next release @alewin? :)

I will fix this in the next release, thanks!

@alewin alewin added this to the 4.0.3 milestone Oct 2, 2024
@alewin alewin moved this to Todo in useWorker TODOs Oct 2, 2024
@naorpeled
Copy link
Collaborator

We're planning on releasing a fix for it soon™️

For anyone seeing this thread and wanting a temporary fix you can add the following to your package.json

 .....
  "overrides": {
    "@koale/useworker": {
      "react": "^17.0.0"
    }
  }
 ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants