Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting "with credentials" option with custom element attribute #35

Open
jasonford opened this issue Jul 16, 2024 · 1 comment
Open

Comments

@jasonford
Copy link

Thanks for the very useful module! I'm running into an issue where my site needs to make requests having "with credentials" set to true. It looks like pdfjs supports this, but I don't see a means to set that at the custom element level with this package.

Happy to submit a PR to this repo for the feature, but I might need to ask a couple of questions to make sure I'm doing it right, and this type of thing might be easier to do rather than help do.

Let me know if this feature sounds good, and if starting to work on a PR sounds good.

@alekswebnet
Copy link
Owner

Hi @jasonford
After the quick research, I didn't find a possible way to do it in PDF.js viewer. Maybe it is worth to dig deeper. Anyway, you are welcome to suggest your variants or submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants