Skip to content

Publish 0.8 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mulimoen opened this issue May 19, 2021 · 7 comments · Fixed by #179
Closed

Publish 0.8 #152

mulimoen opened this issue May 19, 2021 · 7 comments · Fixed by #179

Comments

@mulimoen
Copy link
Collaborator

mulimoen commented May 19, 2021

For 0.8 we have some major changes and additions:

  • DatasetBuilder
  • Extents and Selection
  • Compression filters
  • Attributes

Before we release I'd like to include some additional PRs:

Other pending PRs does not involve breaking changes and can be released as patch bumps.

@aldanor Are there any additional items you would like to see in 0.8?

Closes #164, #168, #170, #172

@aldanor
Copy link
Owner

aldanor commented Oct 6, 2021

@mulimoen Ok, let's try to do it:

#117, #139, #147, #157 - which ones do you think we can squeeze in 0.8? Is there anything else major left hanging?

I'll go over those PRs now and we can try merging things in. If all is fine, I can probably push 0.8 later tonight.

@aldanor aldanor pinned this issue Oct 6, 2021
@aldanor
Copy link
Owner

aldanor commented Oct 6, 2021

#156 would also be VERY nice to squeeze in - I'll get on to that now.

@magnusuMET
Copy link
Contributor

magnusuMET commented Oct 6, 2021

#157 would be very nice for inclusion in 0.8, would make the API more accessible for the users. This requires a rebase for #117. I'd be happy to do this when I have access to my personal computer and you've decided on a merging order. #117 would make hdf5-sys a bit clearer for those who are using this directly (although none of the reverse dependencies on crates.io seem very active), and should be just a small change.

(posting from work alt / @mulimoen)

@aldanor
Copy link
Owner

aldanor commented Oct 6, 2021

Perhaps merge #117 in first?

@magnusuMET
Copy link
Contributor

Would make sense, should be little to no conflict for #139 and #147 from this

@mulimoen
Copy link
Collaborator Author

mulimoen commented Oct 6, 2021

All PRs are rebased against master

@aldanor
Copy link
Owner

aldanor commented Oct 23, 2021

@mulimoen Ok, we've closed all PRs (except the conda one which requires lots of work if we go ahead with it), fixed a bunch new bugs (🤦) and the readme/example will get updated and merged shortly in #178.

Anything else left to do? Otherwise I'll create a version bump PR and maybe clean up the changelog before release, then it should be good to go.

@aldanor aldanor mentioned this issue Oct 23, 2021
@aldanor aldanor unpinned this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants