Skip to content

Remove potential panics in From impl #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mulimoen opened this issue Apr 7, 2021 · 0 comments · Fixed by #147
Closed

Remove potential panics in From impl #142

mulimoen opened this issue Apr 7, 2021 · 0 comments · Fixed by #147

Comments

@mulimoen
Copy link
Collaborator

mulimoen commented Apr 7, 2021

The current signature of the Container object requires extents which implements Into<Extents>. This should be modified to accept TryInto<Extents>, and implementations of From<Foo> for Extents should be changed into TryFrom, as From/Into should never panic.

See #140 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TryFrom over From mulimoen/hdf5-rust
1 participant
@mulimoen