Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Allow updating to kiota-abstractions-go v.1.5.5+ #5124

Open
ashmrtn opened this issue Jan 25, 2024 · 0 comments
Open

Allow updating to kiota-abstractions-go v.1.5.5+ #5124

ashmrtn opened this issue Jan 25, 2024 · 0 comments
Assignees

Comments

@ashmrtn
Copy link
Contributor

ashmrtn commented Jan 25, 2024

Recent updates in the kiota-abstractions-go package made it so that we can't upgrade it past v1.5.5. Attempting to do so without further modifications to corso results in the server responding that it doesn't know how to deserialize the data we're sending

This issue allows tracking the changes made to allow future updates of this the kiota-abstractions-go package

@ashmrtn ashmrtn self-assigned this Jan 25, 2024
aviator-app bot pushed a commit that referenced this issue Jan 29, 2024
Instead of relying on strings pulled from the graph SDK to identify the types of the items we're dealing with use the type of the interface in golang.

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #5124

#### Test Plan

- [ ] 💪 Manual
- [x] ⚡ Unit test
- [ ] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 30, 2024
Disable sending requests to microsoft servers to get API tokens when
using the gock client. This is accomplished by passing in a mock that
always returns no error for auth requests.

**This PR does not go through and make existing tests using gock unit
tests instead of integration tests. That will need to be done
separately**

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [ ] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #5124

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant