Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error states for general, passkey and wallet-connect errors #959

Merged
merged 11 commits into from
Sep 13, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Sep 10, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces new error handling features, updates dependencies, and refactors components in the account-kit/react project.

Detailed summary

  • Added error handling for various scenarios
  • Updated dependencies including msw and msw-storybook-addon
  • Refactored components for improved structure and organization

The following files were skipped due to too many changes: account-kit/react/src/components/auth/card/steps.tsx, account-kit/react/src/components/auth/sections/Footer.tsx, account-kit/react/src/icons/coinbaseWallet.tsx, account-kit/react/.storybook/preview.tsx, account-kit/react/src/components/auth/card/footer/email-not-reveived.tsx, account-kit/react/src/components/auth/card/add-passkey.tsx, account-kit/react/src/icons/walletConnectIcon.tsx, account-kit/react/src/components/auth/card/main.tsx, account-kit/react/src/components/auth/card/passkey.stories.tsx, account-kit/react/src/components/auth/card/eoa.tsx, account-kit/react/src/components/auth/card/error/connection-error.tsx, account-kit/react/src/components/auth/card/index.stories.tsx, account-kit/react/src/components/auth/card/index.tsx, account-kit/react/src/icons/EOAConnectionFailed.tsx, account-kit/react/src/components/auth/card/loading/email.tsx, account-kit/react/src/icons/timeout.tsx, account-kit/react/src/icons/passkeyConnectionFailed.tsx, account-kit/react/src/icons/metamask.tsx, account-kit/react/public/mockServiceWorker.js, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:28pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:28pm

@RobChangCA RobChangCA changed the title Feat: add Error states for General, Passkey and Wallet Connect errors feat: add Error states for General, Passkey and Wallet Connect errors Sep 11, 2024
@RobChangCA RobChangCA changed the title feat: add Error states for General, Passkey and Wallet Connect errors feat: add error states for general, passkey and wallet-connect errors Sep 11, 2024
account-kit/react/src/tailwind/theme.ts Outdated Show resolved Hide resolved
account-kit/react/src/components/button.stories.tsx Outdated Show resolved Hide resolved
account-kit/react/src/components/auth/context.ts Outdated Show resolved Hide resolved
.nvmrc Show resolved Hide resolved
@rthomare
Copy link
Collaborator

Couple of high level thoughts in general to speed up reviews!

  1. Let's make the PRs more atomic. Breaking it down further will help us be better reviewers and help keep each others code quality up.
  2. Let's add more explanation in the summaries on how a reviewer should be expected to text out the experience. it'll help someone historically looking back understand what differences and the evolution of the code base.
  3. Please call out (as a comment or in the summary) if we are intentionally breaking out from convention, it's important that the reviewers see that so we can discuss the tradeoffs.

@RobChangCA RobChangCA merged commit 329abe9 into main Sep 13, 2024
6 checks passed
@RobChangCA RobChangCA deleted the lazer/error-state branch September 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants