From 33bc19c9461a03a9f194c7b86f3a7959784e5323 Mon Sep 17 00:00:00 2001
From: avasisht23 <ajay@alchemy.com>
Date: Mon, 4 Dec 2023 13:51:45 -0500
Subject: [PATCH] feat: add portal to aa-signers

---
 packages/signers/src/portal/__tests__/signer.test.ts | 9 +++++++--
 packages/signers/src/portal/types.ts                 | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/signers/src/portal/__tests__/signer.test.ts b/packages/signers/src/portal/__tests__/signer.test.ts
index c01831efaf..597eda0439 100644
--- a/packages/signers/src/portal/__tests__/signer.test.ts
+++ b/packages/signers/src/portal/__tests__/signer.test.ts
@@ -1,8 +1,13 @@
-import { type RequestArguments } from "@fireblocks/fireblocks-web3-provider";
 import Portal from "@portal-hq/web";
 import { sepolia } from "viem/chains";
 import { PortalSigner } from "../signer.js";
 
+// taken from Portal SDK since not exported
+interface RequestArguments {
+  method: string;
+  params?: unknown[];
+}
+
 describe("Portal Signer Tests", () => {
   it("should correctly get address", async () => {
     const signer = await givenSigner();
@@ -100,7 +105,7 @@ const givenSigner = async (auth = true) => {
     signingStatus: null,
   });
 
-  inner.provider.request = vi.fn(async <T, R>(args: RequestArguments<T>) => {
+  inner.provider.request = vi.fn(async <R>(args: RequestArguments) => {
     switch (args.method) {
       case "eth_accounts":
         return Promise.resolve([
diff --git a/packages/signers/src/portal/types.ts b/packages/signers/src/portal/types.ts
index 620ef74805..bac368e4e9 100644
--- a/packages/signers/src/portal/types.ts
+++ b/packages/signers/src/portal/types.ts
@@ -2,6 +2,7 @@ import type { Address } from "viem";
 
 export interface PortalAuthenticationParams {}
 
+// taken from Portal SDK since not exported
 export type PortalUserInfo = {
   id: string;
   address: Address;