elogind required even if it is configured with systemd in autotools

[KaiJan57]

miraclecast/configure.ac

Line 56 in f3debd5

AS_IF([test "$use_libsystemd" == "yes"],

test does not accept ==, for string comparison just use =. This way everything ./configures just fine.

[albfan]

Looks it supports both.

$ test "1" = "1"; echo $?
0
$ test "1" == "1"; echo $?
0
$ test "1" = "2"; echo $?
1
$ test "1" == "2"; echo $?
1

Better describe why you need this. What error you find with "==". Then we can work on a solution.

"Typo in configure.ac" is the solution for... what?

Closing until you provide more details

[KaiJan57]

OK thats interesting, but for sure did ./configure fail without this change and require elogind even though it was set up with systemd... Quite sure this is the exact problem the author of the last comment on AUR had.
If you really dont believe me, I will reproduce the error message from ./configure as soon as I get to it.

[albfan]

Please avoid subjetive comments on issues.

So this issue description is probably: elogind required even if it is configured with systemd in autotools.

I'm the maintainer of AUR package and didn't see any fail on build, not sure what comment you refer too. Is always easy to add a link.

Sentences like "if you don't believe me" looks pretty personal. We all are busy, so is ok to explain you are not able to show right now. "Let me upload the output of ./configure I'm afk now" is more polite.

at this moment the case will stay closed, just if you have the needed explanation of the error we can investigate

[KaiJan57]

Link to the AUR issue I referred to. (Sorry, I didn't mean to be toxic, and sorry also for engaging in this kind of philosophical discussion, but whether it is easy to include a link or not, that is just as well very subjective, isn't it? ;) )

So here is my output from ./configure --prefix=/usr --sysconfdir=/etc 1> log.txt 2>&1: log.txt
Please see line 94 of that file for the error message, and that very error is fixed by replacing == with = (at least on my side, can't say anything objective about other setups)

[KaiJan57]

Looks it supports both.

$ test "1" = "1"; echo $?
0
$ test "1" == "1"; echo $?
0
$ test "1" = "2"; echo $?
1
$ test "1" == "2"; echo $?
1

Better describe why you need this. What error you find with "==". Then we can work on a solution.

"Typo in configure.ac" is the solution for... what?

Closing until you provide more details

Yes looks like it depends on the setup:

$ test "0" == "0"
sh: 2: test: 0: unexpected operator

[albfan]

Forcing an error here, shows I use bash and you sh

$ test "1" "a" "1"
bash: test: a: se esperaba un operador binario

looks this is bash/sh related.

I'm ok with define that shell agnostic

‘==’ is a synonym for ‘=’

Can you open a PR?