Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid AppOnErr(xxxx) macro in ti83plus.inc #85

Open
bxparks opened this issue Jun 22, 2024 · 0 comments
Open

invalid AppOnErr(xxxx) macro in ti83plus.inc #85

bxparks opened this issue Jun 22, 2024 · 0 comments

Comments

@bxparks
Copy link

bxparks commented Jun 22, 2024

Problem

The definition of the AppOnErr(xxxx) macro in ti83plus.inc is incorrect and does not work. It is currently:

#define AppOnErr xxxx ld HL,xxxx \ CALL APP_PUSH_ERRORH

The error message is:

$ ../../spasm/spasm -I ../../spasm/inc -N rpn83p.asm rpn83p.8xk
Pass one... 
.../mainscanner.asm:30: Error during invocation of macro 'APPONERR'
.../mainscanner.asm:30: warning SW804: Macro 'APPONERR' was given too many arguments, ignoring extras

Solution

It should probably have some parenthesis:

#define AppOnErr(xxxx) ld HL,xxxx \ CALL APP_PUSH_ERRORH

Workaround

Just expand the macro manually when needed:

ld hl, xxxx
call APP_PUSH_ERRORH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant