Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo working? #1

Open
bchr02 opened this issue Oct 1, 2015 · 2 comments
Open

Is this repo working? #1

bchr02 opened this issue Oct 1, 2015 · 2 comments

Comments

@bchr02
Copy link

bchr02 commented Oct 1, 2015

Hello, I was getting ready to create something that basically does what this repo does. But I noticed there hasn't been a lot of activity lately and the readme states that it's not complete.

So I thought I'd ask. Is this repo working? Thanks.

@albanm
Copy link
Owner

albanm commented Oct 1, 2015

Hello,

Well, it works. But it is based on the work done here to make node-pre-gyp pluggable with hosting strategies: mapbox/node-pre-gyp#108

Unfortunately this PR was never accepted despite initial interest.

@bchr02
Copy link
Author

bchr02 commented Oct 2, 2015

So I just tried this out and it worked! Awesome. Thank you!

Any chance you could update your fork albanm/node-pre-gyp to bring in all the recent changes at mapbox/node-pre-gyp?

If @springmeyer isn't willing to pull in your changes maybe it would be better to break the dependency of needing albanm/node-pre-gyp and instead create a new module that can include it's own publish command to in essence do the same thing? So, therefore we could use node-pre-gyp for everything but publish and then use your module to publish.

I really like the work you have done and appreciate it. I am trying to use it for node-oracledb if possible but I need to create a viable solution. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants