Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the class AlastriaProvider #129

Closed
VictorNS69 opened this issue Oct 15, 2020 · 2 comments
Closed

Create the class AlastriaProvider #129

VictorNS69 opened this issue Oct 15, 2020 · 2 comments
Labels
blocked enhancement New feature or request libs

Comments

@VictorNS69
Copy link
Contributor

The idea is to create a class AlastriaProvider which sets the provider the user want (web3, ehter, ...) and checks if this provider has the functions we use in the lib (functions as .eth.abi.encodeFunctionCall), so if any of those functions does not exist, this class will throw an error saying that "this provider is not suported" (yet?).

Also, this class will create a default provider if none is passed as argument. This means to create a new account too.

Then, the lib functions need to be modified to receive an AlastriaProvider instance. Also, this new argument should be the last argument in the function as it will be optional (if none setted, default is created as explained before).

@VictorNS69 VictorNS69 added enhancement New feature or request libs blocked labels Oct 15, 2020
@VictorNS69
Copy link
Contributor Author

VictorNS69 commented Oct 15, 2020

Issue currently blocked because there are other issues with higher priority.

@VictorNS69
Copy link
Contributor Author

VictorNS69 commented Apr 8, 2022

If we migrate to ether-js, this issue is not needed.

See #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request libs
Projects
None yet
Development

No branches or pull requests

1 participant