Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the file UserIdentity.ts #127

Open
VictorNS69 opened this issue Oct 15, 2020 · 1 comment
Open

Remove the file UserIdentity.ts #127

VictorNS69 opened this issue Oct 15, 2020 · 1 comment
Labels
enhancement New feature or request libs under consideration Issue under consideration

Comments

@VictorNS69
Copy link
Contributor

VictorNS69 commented Oct 15, 2020

The idea is to remove the file UserIdentity.ts.

It has been thought that the lib should not encapsulate signing and sending, so the lib consumer should use it to create the transactions and then sign and send it as desired.

The only function that needs to be maintained is

private async getUserNonce(endPoint, address) {
try {
return await endPoint.eth.getTransactionCount(address)
} catch (err) {
console.log(err)
throw err
}
}

The idea is to use the directory utils for common funcitons, as getUserNonce. So a new file needs to be created there with this function (and the others that are needed).

This issue will need the examples to be modified too.

@VictorNS69 VictorNS69 added enhancement New feature or request libs labels Oct 15, 2020
@VictorNS69
Copy link
Contributor Author

This will remove one lib in the #125 (no tx-signer)

@VictorNS69 VictorNS69 added the under consideration Issue under consideration label Apr 8, 2022
@VictorNS69 VictorNS69 pinned this issue Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libs under consideration Issue under consideration
Projects
None yet
Development

No branches or pull requests

1 participant