-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some initial structure and guideline docs #3
Open
llewelld
wants to merge
1
commit into
main
Choose a base branch
from
iss002-structure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
force-pushed
the
iss002-structure
branch
2 times, most recently
from
November 8, 2024 09:18
6098b51
to
b05b89c
Compare
llewelld
requested review from
andrewphilipsmith
and removed request for
andrewphilipsmith
November 8, 2024 09:30
Fixes #1. |
llewelld
force-pushed
the
iss002-structure
branch
from
November 8, 2024 09:41
b05b89c
to
fbe02e2
Compare
penelopeysm
reviewed
Nov 8, 2024
llewelld
force-pushed
the
iss002-structure
branch
3 times, most recently
from
November 8, 2024 15:28
46ff152
to
7ffee95
Compare
penelopeysm
approved these changes
Nov 8, 2024
phinate
reviewed
Nov 8, 2024
phinate
reviewed
Nov 8, 2024
Adds a docs directory with some initial documentation, including guidelines and the notes from the discussion following the first review. Co-authored-by: Penelope Yong <[email protected]> Co-authored-by: Nathan Simpson <[email protected]>
llewelld
force-pushed
the
iss002-structure
branch
from
November 8, 2024 16:04
deb7040
to
03e51eb
Compare
phinate
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @llewelld! Really appreciate your initiative (and the initiative).
Let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a docs directory with some initial documentation, including guidelines and the notes from the discussion following the first review.