Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML checks - Checking tables and bullet lists are styled properly #66

Closed
Angelsaur opened this issue Jan 26, 2021 · 2 comments
Closed
Assignees
Labels
accessibility Improves accessibilty for users with diverse needs Community Inclusion Supports diverse inclusion and builds community documentation Improvements or additions to documentation Milestone 4 MVP accessibility checks

Comments

@Angelsaur
Copy link
Collaborator

Summary

Check that any tables and bullet lists have been styled properly. If they are not styled properly, screen reader software will not recognise what they are and will not convey the information in a way that makes sense to users.

Deadline

20/02/2021

What needs to be done?

View HTML page
The way you view your page’s HTML depends on which browser you’re using. If you’re using:

Google Chrome, right-click the page element you want to check and select ‘inspect’
Safari, right-click the page element you want to check and select ‘inspect element’ - you might need to enable Safari developer tools first
Edge, press ‘F12’, then hold ‘Ctrl’ and ‘B’ - once you’ve done that, left-click the page element you want to check
Firefox, right-click the element you want to check and select ‘inspect element’ - you might need to enable Firefox web developer first
This should open up a panel somewhere on your screen showing the HTML for the page.

Check a few tables and bullet lists from your sample pages. Once you’ve opened up the source code, look out for the following sorts of tags:

for tables, look out for td, th and tr in <>
for bullet lists, look out for ul and li in <>
If you can see these tags, it’s likely the elements have been styled properly.

Who can help?

@Angelsaur Angelsaur added documentation Improvements or additions to documentation accessibility Improves accessibilty for users with diverse needs Community Inclusion Supports diverse inclusion and builds community labels Jan 26, 2021
@Angelsaur Angelsaur added this to the Accessibility milestone Jan 26, 2021
@GeorgiaHCA
Copy link
Collaborator

The bullet lists do indeed have ul and li in the code - so this criterium is met/

For the tables, I've used a 'grid container" component which I took from gov.uk but it doesn't seem to have the tables requirement listed. I think it needs re-styling and reformatting and my guess is that it's because of compyning two different styles systems provided by Marvel and Gov.uk.

Perhaps you would be the best person to help with this @MaxwellRiess?

@GeorgiaHCA GeorgiaHCA added the Milestone 4 MVP accessibility checks label May 24, 2021
@gedankenstuecke
Copy link
Member

Made issue #369 to create an accessibility checklist that can be used for the MVP and going forward. Closing this along with other accessibility checklist items for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improves accessibilty for users with diverse needs Community Inclusion Supports diverse inclusion and builds community documentation Improvements or additions to documentation Milestone 4 MVP accessibility checks
Projects
None yet
Development

No branches or pull requests

5 participants