Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crash on wrong name strings #22

Open
borstessi opened this issue Feb 27, 2020 · 3 comments
Open

App Crash on wrong name strings #22

borstessi opened this issue Feb 27, 2020 · 3 comments

Comments

@borstessi
Copy link

🐛 Bug Report

App crash if the name string isnt found in the eva icon library.

To Reproduce

Steps to reproduce the behavior:
Adding a wrong string for the icon name.

Expected behavior

Instead of throwing a violation there should be a testing mechanism which prevents of throwing a violation and return null instead of the icon with a wrong name string to prevent app crashes.

Link to runnable example or repository (highly encouraged)

React Native Eva Icons Version

newest

Environment information

IOS 13.3 / 13.4
Android 8/9

@mtalhagaoglu
Copy link

i have same problem. how can we check if this icon exist?

@kushagraagent47
Copy link

Hey @mtalhagaoglu you can check here

@joeyfigaro
Copy link

@kushagraagent47 I think what OP means is that the component should handle being passed values for the name prop that don't exist. Right now it throws an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants